Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenAI streaming empty chunk error #69

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix OpenAI streaming empty chunk error #69

merged 2 commits into from
May 1, 2024

Conversation

hramezani
Copy link
Member

Fixes #64

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 1, 2024 •
edited
Loading

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc22d44
Status: ✅  Deploy successful!
Preview URL: https://f509c879.logfire-docs.pages.dev
Branch Preview URL: https://fix-empty-chunk-error.logfire-docs.pages.dev

View logs

@Kludex
Copy link
Member

Kludex commented May 1, 2024 •
edited
Loading

Hold on...

But the chunk was available on the issue, what was not available was the choices list, isn't it the case?

@hramezani
Copy link
Member Author

Hold on...

But the chunk was available on the issue, what was not available was the choices list, isn't it the case?

Yes, let me handle choices as well

@hramezani hramezani requested a review from Kludex May 1, 2024 15:34
@hramezani
Copy link
Member Author

@Kludex I handled the empty choices and added a test for it

@Kludex Kludex merged commit 011e127 into main May 1, 2024
11 checks passed
@Kludex Kludex deleted the fix-empty-chunk-error branch May 1, 2024 16:11
@samuelcolvin samuelcolvin mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index error for Azure OpenAI streaming
2 participants
@hramezani @Kludex