Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 (and adjust code for tokenizer changes). #197

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

matthewwardrop
Copy link
Collaborator

closes: #196

@bashtage
Copy link
Contributor

Is there any expectations the CI runs or needs to be passed?

@matthewwardrop
Copy link
Collaborator Author

Is there any expectations the CI runs or needs to be passed?

Yes... but it is struggling because Python 2.7 and 3.6 no longer exist in GitHub actions support versions. Fixing.

@matthewwardrop matthewwardrop force-pushed the add_support_for_3.12 branch 7 times, most recently from 3fe8560 to d45c7ea Compare November 30, 2023 18:48
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6bd31ca) 98.49% compared to head (8853aee) 98.43%.

Files Patch % Lines
patsy/tokens.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   98.49%   98.43%   -0.07%     
==========================================
  Files          30       30              
  Lines        3131     3132       +1     
  Branches      690      691       +1     
==========================================
- Hits         3084     3083       -1     
- Misses         24       25       +1     
- Partials       23       24       +1     
Flag Coverage Δ
unittests 98.02% <60.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewwardrop matthewwardrop merged commit 8fd7bc1 into master Nov 30, 2023
16 checks passed
@matthewwardrop matthewwardrop deleted the add_support_for_3.12 branch November 30, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with Python 3.12
3 participants