Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Don't write to the fs on module import. #11

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Feb 1, 2019

Avoid writing to the filesystem when the module imports.
This prevents errors when the home directory is
unwriteable.

Closes #10.

CC @PeterJCLaw

Avoid writing to the filesystem when the module imports.
This prevents errors when the home directory is
unwriteable.
@tswast
Copy link
Collaborator Author

tswast commented Feb 1, 2019

Tests pass locally.

$ pytest tests
======================= test session starts ========================
platform darwin -- Python 3.6.4, pytest-3.7.1, py-1.5.4, pluggy-0.7.1
rootdir: /Users/swast/src/pydata-google-auth, inifile:
plugins: pyfakefs-3.5.6
collected 9 items

tests/system/test_auth.py .....                              [ 55%]
tests/unit/test_auth.py ..                                   [ 77%]
tests/unit/test_cache.py ..                                  [100%]

==================== 9 passed in 12.42 seconds =====================

@tswast tswast merged commit 14f0320 into pydata:master Feb 1, 2019
@tswast tswast deleted the issue10-unwritable-home-dir branch February 1, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant