Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_inflate_ip__larger. #3098

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix test_inflate_ip__larger. #3098

merged 2 commits into from
Sep 13, 2024

Conversation

avpai-dinosaur
Copy link
Contributor

This test case was not checking what it was supposed to check (duplicate code of test_inflate_ip__smaller).

Fixes #3096

@avpai-dinosaur
Fix test_inflate_ip__larger.
9bfdbe0 
This test case was not checking what it was supposed to check (duplicate code of test_inflate_ip__smaller)
@avpai-dinosaur avpai-dinosaur requested a review from a team as a code owner September 11, 2024 14:57
bilhox
bilhox requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution ! I left a comment for you.

test/rect_test.py Outdated Show resolved Hide resolved
bilhox
bilhox approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@yunline yunline added tests tests (module) bugfix PR that fixes bug labels Sep 13, 2024
gresm
gresm approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@gresm gresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The docstrings for tests of pygame.Rect.scale_by could also benefit from updating them, but it's probably out of scope of this PR.

@bilhox
Copy link
Contributor

bilhox commented Sep 13, 2024

LGTM. The docstrings for tests of pygame.Rect.scale_by could also benefit from updating them, but it's probably out of scope of this PR.

Indeed I can see that for certain tests. I think it's something a bit linked to the topic of this PR. So I would suggest a change there as gresm mentionned it. Otherwise it will not be fixed in a near future.

MyreMylar
MyreMylar approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit ca640b7 into pygame-community:main Sep 13, 2024
25 checks passed
@ankith26 ankith26 added this to the 2.5.2 milestone Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@bilhox bilhox bilhox approved these changes

@gresm gresm gresm approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug tests tests (module)
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.

Incorrect tests & missing test in rect_test
6 participants
@avpai-dinosaur @bilhox @MyreMylar @gresm @yunline @ankith26