feature: add support for opkg (OpenWrt's package manager) #1053
Conversation
|
Although this is only |
There was a problem hiding this comment.
Thank you for the PR @morrison12! Apologies for the long delay reviewing this. Looks great overall, esp the test coverage! Couple of minor tweaks needed, I’m happy to make these changes when I have the time too if you don’t get there first!
| """ | ||
|
|
||
| if force or (UPDATE_ENTRY not in host.get_fact(Packages)): | ||
| host.get_fact(Packages).update({UPDATE_ENTRY: [UPDATE_ENTRY]}) |
There was a problem hiding this comment.
Note: this won’t work in v3 since facts are no longer cached (fixes so many other issues). You could use host data to achieve the same though (compatible in both 2/3).
| return arch_list | ||
|
|
||
|
|
||
| class Packages(FactBase): |
There was a problem hiding this comment.
For consistency would you mind prefixing all the fact classes Opkg?
|
@morrison12 would you mind giving me write permissions on this branch? I'll fixup those issues to land this |
Done. Apologies for delay: real life exceeding its quota right now.. |
Initial support for
opkg( Openwrt's package manager).Addresses issue #1046.