[WIP] pyinfra/operations: git.config to manage system-level config

[Pirols]

No description provided.

[Fizzadar]

Sorry for the long delay @Pirols - this looks great! Just need to fix the test situation, I can't quite understand why those are failing 🤔

[Pirols]

Sorry for the long delay @Pirols - this looks great!

Hello @Fizzadar, thanks!

Just need to fix the test situation, I can't quite understand why those are failing 🤔

As you might have noticed, I have isolated the faulty (in terms of the tests' coverage) part of this PR into 9972fae, which AFAICT should not be breaking any previous usage of that fact. I have not worked on this in a while, so my memory is not of much use but I had noted the following:

The problematic part is in the fixup commit and it boils down to changing the GitConfig fact to enable the collection of the system level config. The issue is raised by the unit tests and seems to be due to the updated GitConfig returning None instead of a dictionary. This is - surprisingly - happening even for tests where the system flag is not set and the command - and thus the behaviour - should go unchanged.

Now, my 2¢: git config --system works, obviously, at system level and I don't know if that requires some extra configuration in how pyinfra performs tests. In fact, git config --system --list may even output an error: fatal: unable to read config file '/etc/gitconfig': No such file or directory.

Is this of any inspiration to you?