Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more arguments in FindFilesBase #1188

Open
wants to merge 13 commits into
base: 3.x
Choose a base branch
from
Open

Support more arguments in FindFilesBase #1188

wants to merge 13 commits into from

Conversation

JakkuSakura
Copy link
Contributor

@JakkuSakura JakkuSakura commented Aug 27, 2024 •
edited
Loading

This is an attempt to make FindFiles more useful.

It has not been tested yet

closes #1174

Fizzadar
Fizzadar reviewed Sep 1, 2024
View reviewed changes
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, huge improvement! Few linting things to fix and this is ready I think.

@JakkuSakura
Copy link
Contributor Author

Just fixed linting.
one notable change is fname
mypy caught that name is defined in FactBase, thus we can't use name directly

@JakkuSakura
Copy link
Contributor Author

I'm not sure how to express args: List[str] especially it may contain QuoteString

@JakkuSakura
Copy link
Contributor Author

finally...
I also managed to enhance the tests to support dict as argument.

Fizzadar
Fizzadar approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just the test thing (I'll move and merge if I get to it before you :)).

pyinfra/facts/util/units.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fizzadar Fizzadar Fizzadar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make get_fact(FindFiles) more versatile
2 participants
@JakkuSakura @Fizzadar