Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for invalid-getnewargs-ex-returned #10209

Merged

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Fix a false positive for invalid-getnewargs-ex-returned when the tuple or dict has been assigned to a name.

Closes #10208

@mbyrnepr2 mbyrnepr2 added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jan 29, 2025
@mbyrnepr2 mbyrnepr2 added this to the 3.3.5 milestone Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.84%. Comparing base (b2598fa) to head (9b0b8b5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10209   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         175      175           
  Lines       19056    19056           
=======================================
  Hits        18264    18264           
  Misses        792      792           
Files with missing lines Coverage Ξ”
pylint/checkers/classes/special_methods_checker.py 95.45% <100.00%> (ΓΈ)

Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 9b0b8b5

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@mbyrnepr2 mbyrnepr2 merged commit 8138620 into pylint-dev:main Jan 30, 2025
48 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
…tuple or dict has been assigned to a name. (#10209)

(cherry picked from commit 8138620)
mbyrnepr2 added a commit that referenced this pull request Jan 30, 2025
…tuple or dict has been assigned to a name. (#10209) (#10210)

(cherry picked from commit 8138620)

Co-authored-by: Mark Byrne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for invalid-getnewargs-ex-returned
2 participants