Check invalid-name for PEP 695 nodes
#9196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Needs astroid update
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9196 +/- ##
==========================================
+ Coverage 95.76% 95.79% +0.02%
==========================================
Files 173 173
Lines 18694 18726 +32
==========================================
+ Hits 17903 17939 +36
+ Misses 791 787 -4
|
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
changed the title
invalid-name for PEP 695 nodesinvalid-name for PEP 695 nodes
jacobtylerwalls
changed the title
invalid-name for PEP 695 nodesinvalid-name for PEP 695 nodes
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 0de8dd8 |
|
Handled in #9457 |
Merged
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Mar 3, 2024
New Features ------------ - Skip ``consider-using-join`` check for non-empty separators if an ``suggest-join-with-non-empty-separator`` option is set to ``no``. Closes #8701 (`#8701 <https://github.com/pylint-dev/pylint/issues/8701>`_) - Discover ``.pyi`` files when linting. These can be ignored with the ``ignore-patterns`` setting. Closes #9097 (`#9097 <https://github.com/pylint-dev/pylint/issues/9097>`_) - Check ``TypeAlias`` and ``TypeVar`` (PEP 695) nodes for ``invalid-name``. Refs #9196 (`#9196 <https://github.com/pylint-dev/pylint/issues/9196>`_) - Support for resolving external toml files named pylintrc.toml and .pylintrc.toml. Closes #9228 (`#9228 <https://github.com/pylint-dev/pylint/issues/9228>`_) - Check for `.clear`, `.discard`, `.pop` and `remove` methods being called on a set while it is being iterated over. Closes #9334 (`#9334 <https://github.com/pylint-dev/pylint/issues/9334>`_) New Checks ---------- - New message `use-yield-from` added to the refactoring checker. This message is emitted when yielding from a loop can be replaced by `yield from`. Closes #9229. (`#9229 <https://github.com/pylint-dev/pylint/issues/9229>`_) - Added a ``deprecated-attribute`` message to check deprecated attributes in the stdlib. Closes #8855 (`#8855 <https://github.com/pylint-dev/pylint/issues/8855>`_) False Positives Fixed --------------------- - Fixed false positive for ``inherit-non-class`` for generic Protocols. Closes #9106 (`#9106 <https://github.com/pylint-dev/pylint/issues/9106>`_) - Exempt ``TypedDict`` from ``typing_extensions`` from ``too-many-ancestor`` checks. Refs #9167 (`#9167 <https://github.com/pylint-dev/pylint/issues/9167>`_) False Negatives Fixed --------------------- - Extend broad-exception-raised and broad-exception-caught to except*. Closes #8827 (`#8827 <https://github.com/pylint-dev/pylint/issues/8827>`_) - Fix a false-negative for unnecessary if blocks using a different than expected ordering of arguments. Closes #8947. (`#8947 <https://github.com/pylint-dev/pylint/issues/8947>`_) Other Bug Fixes --------------- - Improve the message provided for wrong-import-order check. Instead of the import statement ("import x"), the message now specifies the import that is out of order and which imports should come after it. As reported in the issue, this is particularly helpful if there are multiple imports on a single line that do not follow the PEP8 convention. The message will report imports as follows: For "import X", it will report "(standard/third party/first party/local) import X" For "import X.Y" and "from X import Y", it will report "(standard/third party/first party/local) import X.Y" The import category is specified to provide explanation as to why pylint has issued the message and guidence to the developer on how to fix the problem. Closes #8808 (`#8808 <https://github.com/pylint-dev/pylint/issues/8808>`_) Other Changes ------------- - Print how many files were checked in verbose mode. Closes #8935 (`#8935 <https://github.com/pylint-dev/pylint/issues/8935>`_) - Fix a crash when an enum class which is also decorated with a ``dataclasses.dataclass`` decorator is defined. Closes #9100 (`#9100 <https://github.com/pylint-dev/pylint/issues/9100>`_)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Waiting on astroid 3.1, with pylint-dev/astroid#2330.
Adding these new test files necessitated moving them into a new subfolder to stay under the 50-file limit.