Fixed false positive nested-min-max for nested lists #9323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nesting is useful for finding the maximum in a matrix. Therefore, pylint allows nesting of the form: max(max([[1, 2, 3], [4, 5, 6]])) Closes pylint-dev#9307
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9323 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 173 173
Lines 18767 18767
=======================================
Hits 17981 17981
Misses 786 786
|
Pierre-Sassoulas
requested changes
Dec 26, 2023
There was a problem hiding this comment.
LGTM, great fix ! I'd like to see the primer's result before merging,, I think it depends on
#9330 being merged and then a rebase on it.
Pierre-Sassoulas
added
Blocked π§
|
It can be rebased now :) |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 6d2846d |
Pierre-Sassoulas
approved these changes
Dec 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
Nesting is useful for finding the maximum in a matrix. Therefore, pylint allows nesting of the form: max(max([[1, 2, 3], [4, 5, 6]])) Closes #9307 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit da13c74)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 30, 2023
Nesting is useful for finding the maximum in a matrix. Therefore, pylint allows nesting of the form: max(max([[1, 2, 3], [4, 5, 6]])) Closes #9307 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit da13c74) Co-authored-by: Udi Fuchs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Nesting is useful for finding the maximum in a matrix.
Therefore, pylint now allows nesting of the form:
Closes #9307