Jules - fix pyodide and sysinstall tests. #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map2(). fz_enumerate_font_cmap2() behaves slightly differently from PyMuPDF classic's JM_valid_chars(), in that it can return separate (ucs, gid) pairs with the same <gid>. So tests/test_font.py:test_3933()'s expectations have been changed slightly.
…failure. This test doesn't work when checking `fitz` alias.
|
Harald, it's late here; if you are around to approve this, could you also merge so that we hopefully have a clean test run early on Monday? Thanks. |
JorjMcKie
approved these changes
Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use new fz_enumerate_font_cmap2 on mupdf master.