Support to wildcard a path with --exclude #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
KyleFromNVIDIA
approved these changes
Jan 6, 2025
for more information, see https://pre-commit.ci
|
started the CI. lets see |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 92.01% 92.05% +0.03%
==========================================
Files 20 20
Lines 1315 1321 +6
Branches 247 248 +1
==========================================
+ Hits 1210 1216 +6
Misses 65 65
Partials 40 40 ☔ View full report in Codecov by Sentry. |
|
The test ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#508 add ability to wildcast an
--exclude, however it checkes against the so name, not full path. This prevents to exclude all libs within specific directory.This PR tries to also support it.
cc @KyleFromNVIDIA