Logging regression introduced with 20.27.2

[sigma67]

Issue

Logging is being set up despite cli_run(setup_logging=False), causing virtualenv output to end up in INFO instead of DEBUG

Environment

args = [
    "--app-data",
    app_data_dir.as_posix(),
    "--seeder",
    "app-data",
    self.venv_dir.as_posix(),
    "--no-periodic-update",
]
cli_run(args=args, setup_logging=False)

Only occurs on 20.27.2 or later.

Output of the virtual environment creation

Previously output was logged to DEBUG. Now it is logged to INFO.

[gaborbernat]

PR welcome 👍

[sigma67]

I had a look. In principle the new behavior seems more correct than the old one, which was just using the root logger.

In practice however, if you use cli_run from your app, you have no way of controlling the log level of the output now if you use setup_logging=False.

You can sidestep this by adding log filters, which we did to solve the issue for us. But it's not ideal. I suspect a good solution would require more extensive changes, but my Python logging-fu is not quite there yet I'm afraid.