Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #2799

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 11, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 928afd7 to c30276e Compare November 18, 2024 20:13
@gaborbernat gaborbernat enabled auto-merge (squash) November 18, 2024 23:30
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c30276e to 9927f59 Compare November 25, 2024 20:11
@gaborbernat gaborbernat force-pushed the main branch 3 times, most recently from fe26af4 to 7c0a39f Compare November 26, 2024 01:03
@gaborbernat gaborbernat force-pushed the pre-commit-ci-update-config branch from 14e9288 to 2068bcc Compare November 26, 2024 01:17
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat force-pushed the pre-commit-ci-update-config branch from 3e65f2c to 44ae0eb Compare November 26, 2024 01:31
@gaborbernat gaborbernat disabled auto-merge November 26, 2024 01:33
@gaborbernat gaborbernat merged commit f5d7cb4 into main Nov 26, 2024
10 of 37 checks passed
@gaborbernat gaborbernat deleted the pre-commit-ci-update-config branch November 26, 2024 01:33
@sigma67
Copy link
Contributor

sigma67 commented Jan 10, 2025

Hi @gaborbernat , this is a fairly significant change in logging behavior for us that I'm not sure is intended as it was merged in a pre-commit autoupdate MR:

44ae0eb

Virtualenv output is now landing in INFO instead of DEBUG, likely a side-effect of this change.

Shall I create a separate issue?

@sigma67
Copy link
Contributor

sigma67 commented Jan 10, 2025

For context we are using setup_logging=False with cli_run.

@gaborbernat
Copy link
Contributor

Hi @gaborbernat , this is a fairly significant change in logging behavior for us that I'm not sure is intended as it was merged in a pre-commit autoupdate MR:

44ae0eb

Virtualenv output is now landing in INFO instead of DEBUG, likely a side-effect of this change.

Shall I create a separate issue?

Sure. Which messages?

@sigma67
Copy link
Contributor

sigma67 commented Jan 10, 2025

I have created an issue here: #2820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants