Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add Moran.plot_simulation and Moran_BV.plot_simulation #357

Merged
merged 9 commits into from
Jan 11, 2025

Conversation

martinfleis
Copy link
Member

Another port from splot, this time plot_simulation. Dropping aspect_equal keyword as it does not make sense here given the two axes are using distinct units.

I have also added labels to vertical lines indicating I and EI, so that they show up in legend if you do plt.legend().

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (e38e151) to head (9c9dd75).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #357     +/-   ##
=======================================
- Coverage   81.6%   81.5%   -0.0%     
=======================================
  Files         24      24             
  Lines       3372    3391     +19     
=======================================
+ Hits        2750    2765     +15     
- Misses       622     626      +4     
Files with missing lines Coverage Δ
esda/moran.py 83.3% <100.0%> (+0.6%) ⬆️

... and 1 file with indirect coverage changes

esda/moran.py Outdated Show resolved Hide resolved
esda/moran.py Show resolved Hide resolved
@martinfleis martinfleis requested a review from sjsrey January 5, 2025 17:38
@martinfleis martinfleis changed the title ENH: add Moran.plot_simulation ENH: add Moran.plot_simulation and Moran_BV.plot_simulation Jan 5, 2025
@martinfleis martinfleis merged commit 2be44c2 into pysal:main Jan 11, 2025
12 checks passed
@martinfleis martinfleis deleted the sim branch January 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants