Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: move moran_facet plotting from splot #359

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

martinfleis
Copy link
Member

This is nearly 1:1, I just replaced the scatterplot functions for those we already have here and properly specified which spines should be shown and which not. The resulting plot is the exact version of the one splot does.

Tests do not repeat what is tested in scatter itself, so focusing only on the subplot grid and its specification.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (f5c0a56) to head (634e5c5).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #359     +/-   ##
=======================================
+ Coverage   81.5%   81.8%   +0.3%     
=======================================
  Files         24      24             
  Lines       3406    3432     +26     
=======================================
+ Hits        2777    2807     +30     
+ Misses       629     625      -4     
Files with missing lines Coverage Δ
esda/__init__.py 100.0% <ø> (ø)
esda/moran.py 84.0% <100.0%> (+1.5%) ⬆️

@knaaptime knaaptime merged commit 8ae798d into pysal:main Jan 21, 2025
14 checks passed
@martinfleis martinfleis deleted the missing branch January 22, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants