fixed nearest street test

pysal · Jun 20, 2024 · 0609c66 · 0609c66
1 parent 8794f5c
commit 0609c66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/momepy/functional/_elements.py b/momepy/functional/_elements.py
@@ -465,7 +465,8 @@ def get_nearest_street(
         ids = np.empty(len(buildings), dtype=np.float32)
         ids[:] = np.nan
 
-    ids[blg_idx] = streets.index[str_idx]
+    ids = pd.Series(np.nan, index=buildings.index)
+    ids.iloc[blg_idx] = streets.index[str_idx]
     return ids
 
 

diff --git a/momepy/functional/tests/test_elements.py b/momepy/functional/tests/test_elements.py
@@ -222,7 +222,7 @@ def test_get_nearest_street(self):
 
         streets.index = streets.index.astype(str)
         nearest = mm.get_nearest_street(self.df_buildings, streets, 10)
-        assert (nearest == None).sum() == 137  # noqa: E711
+        assert pd.isna(nearest).sum() == 137  # noqa: E711
 
     def test_get_nearest_node(self):
         nodes, edges = mm.nx_to_gdf(mm.gdf_to_nx(self.df_streets))