-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: first bits of refactored dimension #532
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=====================================
Coverage 97.5% 97.5%
=====================================
Files 24 26 +2
Lines 4121 4187 +66
=====================================
+ Hits 4018 4084 +66
Misses 103 103
|
@jGaboardi I am not sure what is the best way of including the functional API in the documentation for the period when both are included. Let's not add it for now and figure it out before releasing? We'll need to rework the user guide as well so we can do that in one go. |
Works for me. |
Very nice! |
|
All green, we should be ready now. |
Co-authored-by: James Gaboardi <[email protected]>
WIP but comes with a lot of simplification over the original API and quite nice speedups compared to original algos.
Using Prague as a benchmark:
The rest is using roughly the same implementation as before.
@jGaboardi the API change is a bit more radical than I originally anticipated but I believe we should do it properly this time.