ENH: neighbor_distance using Graph and new API

[martinfleis]

Only a boring 10x speedup here 😃

15.3 s ± 362 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
1.5 s ± 4.38 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

It currently prints warnings but those shall be solved by geopandas/geopandas#1832.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.6%. Comparing base (4037c70) to head (27ce3ca).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #555     +/-   ##
=======================================
+ Coverage   97.4%   97.6%   +0.2%     
=======================================
  Files         26      30      +4     
  Lines       4328    4752    +424     
=======================================
+ Hits        4214    4638    +424     
  Misses       114     114             

Files	Coverage Δ
momepy/functional/_distribution.py	100.0% <100.0%> (ø)
momepy/functional/tests/test_distribution.py	100.0% <100.0%> (ø)

[knaaptime]

i've spent a bunch of time trying to copy the momepy and spopt test workflow files, but i cannot get that lovely codecov report thing to trigger for any of my packages

[martinfleis]

@knaaptime I believe it is this https://github.com/apps/codecov. You need to configure the Github app.

[knaaptime]

ah, that would help 🙃 thanks.

weird permissions issue. @sjsrey do you mind turning that on for the whole org?

[knaaptime]

pretty neat we get a global overview of the subpackage coverage... (sorry for commandeering this tread :P)

[martinfleis]

That is cool! And @jGaboardi rocks with spaghetti on the top!

[knaaptime]

as usual 🙄

...pretty impressive runner up with inequality, though...

...dont judge me on tobler. that number is BS :P

[jGaboardi]

That is cool! And @jGaboardi rocks with spaghetti on the top!

The only thing that spaghetti is good at! LOL

[jGaboardi]

LGTM

[sjsrey]

ah, that would help 🙃 thanks.

weird permissions issue. @sjsrey do you mind turning that on for the whole org?

Sure, but what needs to be turned on?

[knaaptime]

@sjsrey try this link https://github.com/apps/codecov and see if you can configure the app for all repositories when you get here

[sjsrey]

@sjsrey try this link https://github.com/apps/codecov and see if you can configure the app for all repositories when you get here

It was already configured for all repositories: