Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: User guide refresh #599

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

martinfleis
Copy link
Member

Sorry, this is a bit large PR. I have updated the notebooks in the user guide to use the new API.

Alongside I've noticed few things related to MultiIndex:

  • some shape stuff did not work
  • tessellation seems to break MultiIndex but I need to have a proper look
  • there was a minor issue in verify_tessellation
  • get_node_id needs updating to rely in indices like everything else. probably as get_nearest_node

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (59affb1).
Report is 85 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #599     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      37     +11     
  Lines       4328    6033   +1705     
=======================================
+ Hits        4214    5911   +1697     
- Misses       114     122      +8     
Files with missing lines Coverage Δ
momepy/functional/_elements.py 99.0% <100.0%> (ø)
momepy/functional/_shape.py 100.0% <100.0%> (ø)

@martinfleis martinfleis marked this pull request as ready for review June 14, 2024 16:03
@martinfleis martinfleis requested a review from jGaboardi June 14, 2024 16:03
@martinfleis martinfleis self-assigned this Jun 14, 2024
@martinfleis
Copy link
Member Author

@jGaboardi I think that this is mergeable now. there are some follow-ups but this is already large enough

@martinfleis martinfleis merged commit 96a8418 into pysal:main Jun 14, 2024
16 checks passed
@martinfleis martinfleis deleted the user-guide-refresh branch June 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants