ENH: add get_nearest_node #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
commented
Jun 14, 2024
| @@ -27,7 +27,7 @@ jobs: | |||
| - name: setup micromamba | |||
| uses: mamba-org/setup-micromamba@v1 | |||
| with: | |||
| environment-file: ci/envs/312-latest.yaml | |||
There was a problem hiding this comment.
I am using some of the geopandas 1.0 api (union_all). GeoPandas will be released sooner than momepy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 37 +11
Lines 4328 6067 +1739
=======================================
+ Hits 4214 5945 +1731
- Misses 114 122 +8
|
jGaboardi
reviewed
Jun 14, 2024
Co-authored-by: James Gaboardi <[email protected]>
jGaboardi
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index-oriented and vectorized alternative of
get_node_id. Also fixes the user guide failure.