-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add Streetscape class #658
Conversation
One thing to note - I have added plots from cadastre and DTM from Prague's data portal to the bubenec.gpkg. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 40 +14
Lines 4328 7157 +2829
=======================================
+ Hits 4214 7013 +2799
- Misses 114 144 +30
|
@jGaboardi FYI, I am not expecting you to review this. |
It is very large. LOL |
This adds code implemented by Alessandro Araldi and his team, wrapped into a user friendly API that can be accessed from momepy. It essentially enables analysis of streetscape outlined in 10.1111/gean.12416.
The code is sloooooooooooooooooooooooo... ah... oooooooooooooooow. But it runs. Anyone is happy to refactor. I have picked some low hanging fruits but it is in a dire need of complete refactoring for which I do not have a capacity. It should follow the logic we have in
street_profile
and its performance but is now several orders of magnitude slower. But hey, it works and allows reproducible research. so yay!