Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: do not fail with 3d nodes - preprocess.remove_false_nodes() #661

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 22, 2024

@jGaboardi jGaboardi added enhancement New feature or request rough edge labels Oct 22, 2024
@jGaboardi jGaboardi self-assigned this Oct 22, 2024
@jGaboardi jGaboardi requested a review from martinfleis October 22, 2024 17:45
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (f6b4be5).
Report is 102 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #661     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.8%     
=======================================
  Files         26      40     +14     
  Lines       4328    7165   +2837     
=======================================
+ Hits        4214    7031   +2817     
- Misses       114     134     +20     
Files with missing lines Coverage Δ
momepy/preprocessing.py 93.8% <100.0%> (+0.5%) ⬆️
momepy/tests/test_preprocess.py 100.0% <100.0%> (ø)

@jGaboardi jGaboardi requested a review from martinfleis October 23, 2024 16:24
Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi jGaboardi requested a review from martinfleis October 23, 2024 19:34
@martinfleis martinfleis changed the title graceful failure with 3d nodes - preprocess.remove_false_nodes() ENH: do not fail with 3d nodes - preprocess.remove_false_nodes() Oct 23, 2024
@martinfleis
Copy link
Member

pre-commit.ci autofix

@martinfleis martinfleis merged commit f1965cc into pysal:main Oct 23, 2024
14 of 15 checks passed
@jGaboardi jGaboardi deleted the GH657_3d_false_nodes branch October 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rough edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_false_nodes throws an unexpected error
2 participants