Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing failed tests for new release #105

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Fixing failed tests for new release #105

merged 3 commits into from
Oct 28, 2022

Conversation

pedrovma
Copy link
Member

No description provided.

@jGaboardi
Copy link
Member

jGaboardi commented Oct 28, 2022

Failure due to numpy.linalg.LinAlgError. And it is affecting Windows Py310.

self = <spreg.tests.test_panel_re.Test_Panel_RE_Error testMethod=test_Panel>
    def test_Panel(self):
>       reg = Panel_RE_Error(
            self.y,
            self.x,
            w=self.w,
            name_y=self.y_name,
            name_x=self.x_names,
            name_ds=self.ds_name,
        )

spreg\tests\test_panel_re.py:104: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
spreg\panel_re.py:754: in __init__
    BasePanel_RE_Error.__init__(self, bigy, bigx, w, epsilon=epsilon)
spreg\panel_re.py:597: in __init__
    vm1 = np.linalg.inv(v)
<__array_function__ internals>:180: in inv
    ???
C:\Users\runneradmin\micromamba-root\envs\test\lib\site-packages\numpy\linalg\linalg.py:552: in inv
    ainv = _umath_linalg.inv(a, signature=signature, extobj=extobj)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

err = 'invalid value', flag = 8

    def _raise_linalgerror_singular(err, flag):
>       raise LinAlgError("Singular matrix")
E       numpy.linalg.LinAlgError: Singular matrix

@jGaboardi
Copy link
Member

Also, the error seems familiar. I've seen it recently, but can't remember where...

@jGaboardi
Copy link
Member

It's actually here in #56.

@pedrovma
Copy link
Member Author

Any idea why it passed on #99 and suddenly returned?

@jGaboardi
Copy link
Member

No idea at all for now. Trying rerunning now.

@pedrovma
Copy link
Member Author

I tried, but can't replicate the error. I will omit these tests for now until we find out what is going on.

@pedrovma pedrovma merged commit b7377e4 into pysal:master Oct 28, 2022
@jGaboardi
Copy link
Member

error also here: #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants