Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit] Add pyproject-fmt to normalize the pyproject.toml #846

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Pierre-Sassoulas
Copy link
Member

Will prevent most issues when doing parallel modifications of the pyproject.toml conf. (Every changes in pyproject.toml is automated).

@Pierre-Sassoulas Pierre-Sassoulas added code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) dependencies Pull requests that update a dependency file labels Nov 20, 2024
@Pierre-Sassoulas Pierre-Sassoulas added the skip-changelog Can be missed from the changelog. label Nov 20, 2024
@BeyondEvil
Copy link
Contributor

Are the changes to pyproject.toml made by the formatter?

@Pierre-Sassoulas
Copy link
Member Author

Yes ! (See 7be605d)

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pierre-Sassoulas Pierre-Sassoulas merged commit 69de0b6 into master Nov 20, 2024
34 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-pyproject-fmt branch November 20, 2024 15:23
@Pierre-Sassoulas
Copy link
Member Author

Oof, there's been a new issue introduced in the mypy MR, unlucky : #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality This PR has to do with improving code readability/quality ( refactoring, etc. ) dependencies Pull requests that update a dependency file skip-changelog Can be missed from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants