-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed invalid regex handling in filterwarnings #13124
Open
virendrapatil24
wants to merge
11
commits into
pytest-dev:main
Choose a base branch
from
virendrapatil24:fix-invalid-regex-in-filterwarnings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ca22e6f
handles invalid regex for filterwarnings
virendrapatil24 2688436
adds testcase for invalid regex
virendrapatil24 42b50b4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0f6868d
adds changelog
virendrapatil24 745083d
Merge branch 'fix-invalid-regex-in-filterwarnings' of https://github.…
virendrapatil24 e915437
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3cddb3c
updates error syntax
virendrapatil24 ba62c29
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3119e02
updates changelog desc
virendrapatil24 913d388
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d5d8608
error fix
virendrapatil24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Improved handling of invalid regex patterns for filter warnings by providing a clear error message. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -511,6 +511,22 @@ def test_hidden_by_system(self, pytester: Pytester, monkeypatch) -> None: | |
result = pytester.runpytest_subprocess() | ||
assert WARNINGS_SUMMARY_HEADER not in result.stdout.str() | ||
|
||
def test_invalid_regex_in_filterwarning(self, pytester: Pytester) -> None: | ||
self.create_file(pytester) | ||
pytester.makeini( | ||
""" | ||
[pytest] | ||
filterwarnings = | ||
ignore::DeprecationWarning:* | ||
""" | ||
) | ||
result = pytester.runpytest_subprocess() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should assert on the exit code also |
||
result.stderr.fnmatch_lines( | ||
[ | ||
"*Invalid regex '*': nothing to repeat at position 0*", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be more thorough to test on the whole "while parsing ..." output? |
||
] | ||
) | ||
|
||
|
||
@pytest.mark.skip("not relevant until pytest 9.0") | ||
@pytest.mark.parametrize("change_default", [None, "ini", "cmdline"]) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.