External Treasury with config as delegate #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swimricky is attempting to deploy a commit to the pyth-web Team on Vercel. To accomplish this, @swimricky needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
guibescos
reviewed
Aug 2, 2023
|
|
||
| let mut simulator = DispenserSimulator::new().await; | ||
| let claimant_1 = Keypair::new(); | ||
| let claimant_1_airdrop_ix = system_instruction::transfer( |
There was a problem hiding this comment.
Can we replace this by an airdrop function in dispenser_simulator
guibescos
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the treasury to be externally initialized and supplied with tokens. The config will have to be approved as a delegate using the spl-token
approveinstruction.This provides 2 benefits:
revokeinstruction)Notes
approve_amountfor the config/delegate is less than the total amount in the treasury, we will need to monitor thetreasury.delegated_amountand periodically re-submit anapproveix.