feat(price_pusher): make jito bundles independent #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
commented
May 12, 2024
| ); | ||
| for (let i = 0; i < priceIds.length; i += UPDATES_PER_JITO_BUNDLE) { | ||
| const transactionBuilder = this.pythSolanaReceiver.newTransactionBuilder({ | ||
| closeUpdateAccounts: true, |
There was a problem hiding this comment.
Now we can close VAA accounts immediately since the VAA account is not reused in other bundles.
guibescos
changed the title
jayantk
approved these changes
May 13, 2024
guibescos
force-pushed
the
pusher-improvement
branch
from
edabc4c to
8bb7b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating price feed accounts on Solana, previously we would first send a Jito bundle that posts the VAA (and the first 7 price updates), then wait for that bundle to land and then send bundles that reuse the VAA that got posted in the first bundle.
I think a more robust and simple behavior is making every bundle independent from the others. Each bundle posts it's own VAA and 7 price updates based on that VAA, then closes the VAA.
I am hoping this change will reduce latency and make the service more robust (since it just needs to "spray and pray" bundles). It will also make it easier to reason at the behavior when we increase the frequency of updates.