This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add initial version of pyth sdk js #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
LGTM. Left a couple minor comments, but overall seems fine.
One bigger question to consider is how will this SDK relate to https://github.com/pyth-network/pyth-client-js ? Are we going to deprecate one in favor of the other? Merge the two in some way? Or maybe pyth-client-js becomes pyth-solana-js or something like that?
- Make json schema in TS to be the exact same. - Adds toJson and moves constructor to fromJson
Yes exactly, in the future that will be replaced by pyth-solana-js but it's not the priority for now 😅 |
drozdziak1
suggested changes
Apr 20, 2022
tompntn
approved these changes
Apr 21, 2022
drozdziak1
approved these changes
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no readme, to be added later.