Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CI errors #244

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Fix some CI errors #244

merged 5 commits into from
Dec 23, 2024

Conversation

bnavigator
Copy link
Collaborator

@bnavigator bnavigator commented Dec 23, 2024

Fixes:

  • Ubuntu dropped the libopenblas-base "transition" package
  • Mambaforge is deprecated
  • Windows mamba commands silently fail
  • macOS conda MKL error during pytest collection

@bnavigator bnavigator marked this pull request as ready for review December 23, 2024 14:15
@murrayrm murrayrm merged commit a2ee35a into python-control:master Dec 23, 2024
77 checks passed
@slivingston
Copy link
Member

Windows mamba commands silently fail

@bnavigator I looked in the recent CI logs, but I did not find evidence about the mamba command failing silently. Can you show me?

Also, I am motivated to ask because a mamba command is used similarly in python-control CI jobs: https://github.com/python-control/python-control/blob/a2c3b4c8db5558181357d2762e2285ae2ea01dc5/.github/workflows/os-blas-test-matrix.yml#L312

@roryyorke
Copy link
Collaborator

looks good, thanks @bnavigator .

@bnavigator
Copy link
Collaborator Author

bnavigator commented Dec 24, 2024

Yes, I noticed that it works on the python-control jobs. But it failed here: https://github.com/python-control/Slycot/actions/runs/12467342357/job/34797033932#step:7:27 The commands just printed out the current windows version (!?)

See conda-incubator/setup-miniconda#371

@bnavigator
Copy link
Collaborator Author

Oh, it also does not work on the python-control jobs: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:7:27
The installs for slycot do not happen. Notice how the tests are automatically skipped by pytest: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:8:165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants