Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ducky_skull #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

decorator-factory
Copy link
Member

A ducky with a skull 💀

image

A small shade is added to the body to increase the contrast of the skull teeth. (otherwise you can't see them at all, especially in the small version)

@kosayoda
Copy link
Member

Thoughts on something like this instead? Front facing to keep the same 💀 style to avoid weird perspective issues, looks like its turning its head

I redid the skull to avoid licensing issues
duckyskull

@decorator-factory
Copy link
Member Author

Front facing to keep the same skull style

But all the other duckies are facing left. Not sure how to make it work with the skull

I redid the skull to avoid licensing issues

I though twemoji were under a creative commons license https://github.com/twitter/twemoji/blob/master/LICENSE-GRAPHICS

@gustavwilliam
Copy link
Member

@kosayoda that looks pretty nice imo.

Also, we should be fine using Twemojis (like in a lot of our other assets). I'm under the impression that the way we're using it here is allowed, especially since we give credits in this repo.

@kosayoda
Copy link
Member

But all the other duckies are facing left. Not sure how to make it work with the skull

I think facing it left makes it thematically different from 💀 (I'm assuming that's the reason for ducky_skull), also ducky_sphere isn't strictly left facing either

I though twemoji were under a creative commons license...
Also, we should be fine using Twemojis (like in a lot of our other assets)....

whoops, wasn't sure what license applied off the top of my head

I'm fine with either version, so it's up to @decorator-factory, I can add a commit with my version or merge this one as is

@decorator-factory
Copy link
Member Author

But all the other duckies are facing left

Actually ducky_sphere is an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants