-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image -> Arrow support #8330
base: main
Are you sure you want to change the base?
Image -> Arrow support #8330
Conversation
ceb14be
to
309c5e2
Compare
* Fixed format, only for 4 channel images
* structs can't be encoded this way, they need to have one child array per struct member. * i.e. struct of arrays, rather than an array of structs.
* basic safety included * only respecting the types we emit
c10beff
to
97eb7c0
Compare
for more information, see https://pre-commit.ci
Added basic Windows is failing, so that's something that's going to need digging. And somehow codecov is failing before most of the runs have gone, so not sure what's up there. |
Windows AMD64 is failing on pillow arrow tests as well as the python version windows matrix:
Windows x86, Windows pypy, manylinux wheels and MacOS Arm64 and 10.15 X86_64 are failing on pyarrow install/compilation, instead of installing the prebuilt wheel. (I'm not sure why MacOS Arm64 is failing, as that's my dev platform). We're going to have to look at either compile time prerequisites, a lighter library with lots of binaries, or potentially skipping tests if pyarrow doesn't compile. |
Co-authored-by: Andrew Murray <[email protected]>
Co-authored-by: Andrew Murray <[email protected]>
Co-authored-by: Andrew Murray <[email protected]>
Co-authored-by: Andrew Murray <[email protected]>
("HSV", ["L", "F"]), | ||
), | ||
) | ||
def test_invalid_array_type(mode: str, dest_modes: List[str]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_invalid_array_type(mode: str, dest_modes: List[str]) -> None: | |
def test_invalid_array_type(mode: str, dest_modes: list[str]) -> None: |
Partial implementation of #8329.
This is for discussion -- there are a number of issues.
Changes proposed in this pull request:
__arrow_c_array__
and__arrow_c_schema__
support for reading Pillow images in Arrow capable libraries.Issues:
Todo:
For Review: