Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding blurb for anyone, if logged in user is core-dev. #11

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Allow adding blurb for anyone, if logged in user is core-dev. #11

wants to merge 12 commits into from

Conversation

Mariatta
Copy link
Member

No description provided.

@Mariatta Mariatta added the black out Apply to PR. It will run "black" label Dec 30, 2018
@codecov
Copy link

codecov bot commented Dec 30, 2018 •
edited
Loading

Codecov Report

Merging #11 into master will increase coverage by 15.89%.
The diff coverage is 88.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
+ Coverage   61.22%   77.11%   +15.89%     
===========================================
  Files           3        3               
  Lines          49      118       +69     
  Branches        3        9        +6     
===========================================
+ Hits           30       91       +61     
- Misses         19       27        +8
Impacted Files Coverage Δ
blurb_it/util.py 64.81% <100%> (+14.81%) ⬆️
tests/test_util.py 87.09% <85.18%> (-12.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c225618...c20e8e9. Read the comment docs.

@black-out
Copy link

black-out bot commented Dec 30, 2018

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • blurb_it/main.py
  • blurb_it/util.py
  • tests/test_util.py
    (I'm a bot 🤖)

@black-out black-out bot removed the black out Apply to PR. It will run "black" label Dec 30, 2018
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 16:23 Inactive
@Mariatta Mariatta added the black out Apply to PR. It will run "black" label Dec 30, 2018
@black-out
Copy link

black-out bot commented Dec 30, 2018

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • blurb_it/main.py
    (I'm a bot 🤖)

@black-out black-out bot removed the black out Apply to PR. It will run "black" label Dec 30, 2018
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 16:32 Inactive
@Mariatta Mariatta added the black out Apply to PR. It will run "black" label Dec 30, 2018
@black-out
Copy link

black-out bot commented Dec 30, 2018

🐍🌚🤖 @Mariatta, I've formatted these files using black:

  • blurb_it/main.py
    (I'm a bot 🤖)

@black-out black-out bot removed the black out Apply to PR. It will run "black" label Dec 30, 2018
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 16:48 Inactive
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 17:03 Inactive
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 17:12 Inactive
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 17:15 Inactive
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 20:19 Inactive
@Mariatta Mariatta temporarily deployed to blurb-it December 30, 2018 20:24 Inactive
@Mariatta Mariatta added the wip work in progress label Jan 2, 2019
Base automatically changed from master to main January 18, 2021 20:51
@CAM-Gerlach
Copy link
Member

FYI, this will work for core triagers too now with python/core-workflow#460 implemented, assuming you're checking people's actual role/permissions as opposed to hardcoding a list of core devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed wip work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @CAM-Gerlach @the-knights-who-say-ni