Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114240: Skip verifying pip SBOM entry against PyPI if offline outside CI #114255

Closed

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jan 18, 2024

Closes #114240 This PR implements my proposal from this comment: #114240 (comment)

We decide whether to exit(1) or skip based on the presence of the CI environment variable. If there's another existing standard that we're using for this sort of behavior happy to use that instead.

@befeleme Would this work for your use-case?

@befeleme
Copy link
Contributor

In theory, probably yes. I can't verify, since as we don't ship Python's bundled pip (#114244) the script fails a bit sooner for us:

    if len(pip_wheels) != 1:
        print("Zero or multiple pip wheels detected in 'Lib/ensurepip/_bundled'")
        sys.exit(1)

@sethmlarson
Copy link
Contributor Author

I've closed this in favor of #114450, all of these requirements were pretty tightly linked so combined into one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run regen-sbom in regen-all - it requires internet access
2 participants