Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123954: proposal for improving logic for setting SSL exceptions #128391

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

gh-123954: proposal for improving logic for setting SSL exceptions #128391

Changes from 11 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
da3968c
introduce semantic types for SSL packed errors
picnixz Dec 31, 2024
704e6e3
correct error deduction in `fill_and_set_sslerror` and `_setSSLError`
picnixz Dec 31, 2024
864339a
pre-initialize default exception attributes
picnixz Dec 31, 2024
87a501d
extract logic for fetching library and reason
picnixz Dec 31, 2024
7cb16c0
extract logic for formatting error message
picnixz Dec 31, 2024
4bd14a0
extract logic for building simple error message
picnixz Dec 31, 2024
c29f0f1
extract logic for building SSL verification exceptions
picnixz Dec 31, 2024
d8de992
upgrade logic for building SSL exceptions
picnixz Dec 31, 2024
ba1bf20
fix various issues
picnixz Dec 31, 2024
11ee17c
use `PyOS_snprintf` instead of `PyUnicode_FromFormat`
picnixz Jan 1, 2025
45c7a1e
fix Windows compilation
picnixz Jan 1, 2025
4362dae
Apply suggestions from code review
picnixz Jan 1, 2025
31ce5f0
Update Modules/_ssl.c
picnixz Jan 1, 2025
2fbcae2
post-merge
picnixz Jan 2, 2025
fd7d3ec
use `_Py_hashtable_t` for `err_codes_to_names`
picnixz Jan 3, 2025
7772113
use `_Py_hashtable_t` for `lib_codes_to_names`
picnixz Jan 3, 2025
4a2ed1d
post-merge
picnixz Jan 3, 2025
630c2b5
fix compilation?
picnixz Jan 3, 2025
98c8b99
attempt various things
picnixz Jan 3, 2025
133ec9f
try even more things!
picnixz Jan 3, 2025
fb5d800
:@
picnixz Jan 3, 2025
d6a0529
:@@@@@@@@@@@@@@
picnixz Jan 3, 2025
bb043b2
skip duplicated entries if they are correct
picnixz Jan 3, 2025
f836684
log more stuff
picnixz Jan 3, 2025
db3ed1c
change hash function key comparator?
picnixz Jan 4, 2025
7a198d4
revert macro
picnixz Jan 4, 2025
93a7a9b
full debug
picnixz Jan 4, 2025
95e1021
remove un-necessary specializations
picnixz Jan 4, 2025
b8f0cce
select when to use verbose SSL errors
picnixz Jan 5, 2025
689568f
reduce the number of format units
picnixz Jan 5, 2025
5583aa5
optimize `format_ssl_error_message`
picnixz Jan 5, 2025
a0ab1c2
temporarily patch CI
picnixz Jan 5, 2025
6b38769
fix assertions
picnixz Jan 5, 2025
3ecba48
now fix assertions correctly
picnixz Jan 5, 2025
d7f1ab1
use ImportWarning insteaad of RuntimeWarning
picnixz Jan 5, 2025
32f7cba
clear exception after emitting the warning
picnixz Jan 5, 2025
a88ec91
fix error path when formatting message
picnixz Jan 9, 2025
a9a6a50
Merge remote-tracking branch 'upstream/main' into perf/ssl/error-123954
picnixz Jan 11, 2025
68f8bc7
include hexadecimal error code value when reporting unknown error
picnixz Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading