gh-129603: Don't segfault if sqlite3.Row description is None #129604
Conversation
| @@ -151,9 +150,13 @@ pysqlite_row_subscript(PyObject *op, PyObject *idx) | |||
| PyObject *item = PyTuple_GetItem(self->data, _idx); | |||
| return Py_XNewRef(item); | |||
| } else if (PyUnicode_Check(idx)) { | |||
| nitems = PyTuple_Size(self->description); | |||
| if (Py_IsNone(self->description)) { | |||
| PyErr_Format(PyExc_IndexError, "No item with key %R", idx); | |||
There was a problem hiding this comment.
IMO, this should be a KeyError, but that would create an inconsistency with L174. Moreover, we should also improve that error message by aligning it to this.
There was a problem hiding this comment.
IMO it should have been a dedicated exception type inheriting from LookupError but the ship has already sailed.
Now, since using the named field instead of its position is equivalent to row[get_index(field_name)], I think it's fine to keep the IndexError (even though it could be surprising at first).
Improving the error message may be good or documenting that an IndexError is raised for invalid indices or invalid keys (if it's not already done).
erlend-aasland
force-pushed
the
sqlite/row-description-is-none
branch
from
ae502d7 to
6f029cd
Compare
erlend-aasland
added
needs backport to 3.12
|
Alternatively, we could disallow instantiation of |
pysqlite_Row->description == PyNone#129603