Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.13 and use 3.12 to build sdist and docs #205

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 5, 2024

I added 3.13 to tox and the CI, then ran tox -e py313 and for each package that needed upgrading for Python 3.13, ran something like:

pip-compile --generate-hashes --output-file=requirements.txt requirements.in --upgrade-package aiohttp

I also used pip-tools on Python 3.12 because we have 3.12 on the downloads and docs servers.

Then also bumped to use Python 3.12 to build the sdist and docs on the CI.


I didn't add 3.14 for testing yet, because we want to use --only-binary and there's some things which don't have 3.14 binaries yet (coverage was the first).

@hugovk
Copy link
Member Author

hugovk commented Jan 9, 2025

@sethmlarson How do these pip-compile updates look?

@hugovk
Copy link
Member Author

hugovk commented Jan 14, 2025

To resolve the conflict, I deleted requirements.txt, ran pip-compile --generate-hashes --output-file=requirements.txt requirements.in and manually fixed the --only-binary :all: bug (jazzband/pip-tools#2082).

Then upgraded aiohttp and attrs in dev-requirements.txt so it matches those in requirements.txt.

Copy link
Collaborator

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Hugo!

@hugovk hugovk merged commit 268cc86 into python:master Jan 14, 2025
12 checks passed
@hugovk hugovk deleted the add-3.13 branch January 14, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants