[llava][8/N] Add Multimodal Runner #4354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4354
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 649f742 with merge base 15815dd ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
added a commit
that referenced
this pull request
Jul 23, 2024
ghstack-source-id: a10394db3f494e2848be8f64f0e547610683bde9 Pull Request resolved: #4354
facebook-github-bot
added
the
CLA Signed
larryliu0820
changed the title
[ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 23, 2024
ghstack-source-id: b3927ceeddcdfa3bb6239cbb8b0c8b6a4692687c Pull Request resolved: #4354
[ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 23, 2024
ghstack-source-id: 063e7d5cfd9456fe1f36d3304909d86296daa0aa Pull Request resolved: #4354
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| ${CMAKE_CURRENT_SOURCE_DIR}/../../../../extension/llm/tokenizer/tiktoken.cpp | ||
| ) | ||
| list(APPEND _multimodal_runner__srcs | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../tokenizer/llama_tiktoken.cpp |
There was a problem hiding this comment.
${CMAKE_CURRENT_SOURCE_DIR}/../../llama2/tokenizer/llama_tiktoken.cpp
?
There was a problem hiding this comment.
Yeah I'll probably delete this
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 619d9c986307f7a78cf4d1336a570d5eeea58019 Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: c221ef16463ea899f3c7a36b373441ac86bf385a Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: ce9de989b0a4ab7b07406be1140d2bf470beda5e Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 20582c843e4506346ba94792b3328f0d2a8e8fe0 Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 1e20fbb5e7cff70e45686d25187684d99e7d3762 Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iseeyuan
reviewed
Jul 30, 2024
| @@ -134,6 +134,7 @@ union XNodeUnion { | |||
| XNNConcatenate4: _XNNCat, | |||
| XNNStaticSlice, | |||
| XNNScaledDotProductAttention, | |||
| XNNBatchMatrixMultiply: _XNNNode2x1, | |||
There was a problem hiding this comment.
Are those be landed in a separate PR?
larryliu0820
added a commit
that referenced
this pull request
Jul 31, 2024
ghstack-source-id: d72da351e7eb7ca69eeaf9241bc604aeaf3bc139 Pull Request resolved: #4354
larryliu0820
added a commit
that referenced
this pull request
Aug 2, 2024
ghstack-source-id: d72da351e7eb7ca69eeaf9241bc604aeaf3bc139 Pull Request resolved: #4354
Differential Revision: [D60101911](https://our.internmc.facebook.com/intern/diff/D60101911) [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Aug 2, 2024
ghstack-source-id: 24a98807fe83f75795939d89b8edc3b24bf1eb71 Pull Request resolved: #4354
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D60101911