Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Android app artifact path after #5004 #5050

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 3, 2024

Fixes #5048

This was missed in #5004

Copy link

pytorch-bot bot commented Sep 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5050

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (30 Unrelated Failures)

As of commit f5701b5 with merge base 35d0f59 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor

guangy10 commented Sep 3, 2024

@huydhn Thanks for the fix!

@kirklandsign let's make sure you tested w/ workflow android-perf via worfklow dispatch for future changes

@facebook-github-bot facebook-github-bot merged commit 0293cac into main Sep 3, 2024
13 of 43 checks passed
@facebook-github-bot facebook-github-bot deleted the fix-android-artifacts-path-after-5004 branch September 3, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy artifacts to Device Farm
4 participants