Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QNN chipset with the device pool #5098

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

guangy10
Copy link
Contributor

@guangy10 guangy10 commented Sep 4, 2024

No description provided.

Copy link

pytorch-bot bot commented Sep 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5098

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 Cancelled Jobs, 1 Unrelated Failure

As of commit 9062a09 with merge base ae05ed8 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2024
@guangy10 guangy10 marked this pull request as ready for review September 4, 2024 23:45
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me know when you need other pools created for S23/24

@guangy10
Copy link
Contributor Author

guangy10 commented Sep 4, 2024

Waiting for the scheduled job https://github.com/pytorch/executorch/actions/runs/10711326499. Shouldn't have export issue. Models won't be runnable as the new android app is not connected yet

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the match_qnn_chipset_w_device_pool branch from a16b685 to 9062a09 Compare September 4, 2024 23:57
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 merged commit e4a2322 into main Sep 5, 2024
74 of 83 checks passed
@guangy10 guangy10 deleted the match_qnn_chipset_w_device_pool branch September 5, 2024 01:52
@guangy10 guangy10 requested a review from shewu-quic September 5, 2024 02:05
@guangy10 guangy10 restored the match_qnn_chipset_w_device_pool branch September 5, 2024 02:06
@guangy10
Copy link
Contributor Author

guangy10 commented Sep 5, 2024

LGTM! Let me know when you need other pools created for S23/24

@huydhn llama is going to run on S24. Is #4524 still a blocker?

@guangy10 guangy10 deleted the match_qnn_chipset_w_device_pool branch September 5, 2024 02:09
@kirklandsign
Copy link
Contributor

LGTM! Let me know when you need other pools created for S23/24

@huydhn llama is going to run on S24. Is #4524 still a blocker?

Sorry forgot to update #4524. I looked into this and feel like APK SDK level is not a problem to the failure, but I can't figure out the root cause either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants