-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.5 Release] Clarify banner on main docs page #7811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7811
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 30 PendingAs of commit 4db7549 with merge base f2f7e7c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 21, 2025
SS-JIA
force-pushed
the
ssjia-update-doc
branch
from
January 21, 2025 22:38
7ac5367
to
1504f73
Compare
SS-JIA
force-pushed
the
ssjia-update-doc
branch
from
January 21, 2025 22:51
1504f73
to
4db7549
Compare
mergennachin
approved these changes
Jan 21, 2025
@pytorchbot cherry-pick --onto release/0.5 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Clarify banner on main docs page (cherry picked from commit b04912f)
Cherry picking #7811The cherry pick PR is at #7813 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
SS-JIA
added a commit
that referenced
this pull request
Jan 22, 2025
[0.5 Release] Clarify banner on main docs page (#7811) Clarify banner on main docs page (cherry picked from commit b04912f) Co-authored-by: Sicheng Stephen Jia <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Clarify banner on main docs page
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Clarify banner on main docs page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As title. Now that we are nearing the release of
v0.5.0
, the banner on the main page of the documentation can be a bit confusing since the mentioned version will not match. Rather than just updatingv0.4.0
tov0.5.0
, I believe the banner is trying to convey that our API lifecycle and deprecation policy is in effect as of v0.4.0 which was the beta release of ExecuTorch.To account for this, I've updated the banner to be more clear on why v0.4.0 is mentioned specifically.