[executorch] Create target for named_data_map #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8110
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 2a87d02 with merge base 3413971 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68972364 |
lucylq
added a commit
that referenced
this pull request
Jan 31, 2025
^ Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) ghstack-source-id: 264108696 Pull Request resolved: #8110
^ Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68972364 |
lucylq
added a commit
that referenced
this pull request
Jan 31, 2025
Pull Request resolved: #8110 named_data_map depends on tensor_layout, which depends on exec_lib. Move it out from core, as we have a circular dep when exec_lib is part of core. Also make TensorLayout::create return a const. Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) ghstack-source-id: 264109129
dbort
approved these changes
Jan 31, 2025
^ Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68972364 |
lucylq
added a commit
that referenced
this pull request
Jan 31, 2025
Pull Request resolved: #8110 named_data_map depends on tensor_layout, which depends on exec_lib. Move it out from core, as we have a circular dep when exec_lib is part of core. Also make TensorLayout::create return a const. ghstack-source-id: 264157518 Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/)
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
^
Differential Revision: D68972364