-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUD] Better test info pages #6211
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
select | ||
t.name, | ||
t.classname, | ||
t.file, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm, what is the difference between file file
and invoking_file
? They are 2 columns on https://torchci-git-csl-testx-fbopensource.vercel.app/tests/search?name=test_mm_plus_mm&suite=TestPatternMatcher&file=inductor%2Ftest_pattern_matcher.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file comes from pytest/the test runner and invoking file comes from run_test.py and is not formatted the same way a file name is. I'm not sure about which is more accurate, especially in the case of cpp files, so it shows both
Some more thoughts I have:
|
I am not sure which part this refers to but I changed the job filter to say filter instead of search, which might help? |
https://hud.pytorch.org/flakytest?name=test_mm_plus_mm&suite=TestPatternMatcher&limit=100
Changes the flakytest page to redirect to a search page. Double clicking on a row brings you to a page about the individual test. The individual test page has a bar chart of runs from the past 3 days, and the info that used to be on the flakytest page (list of jobs the test failed or was rerun)
Old:
New:
https://torchci-git-csl-testx-fbopensource.vercel.app/flakytest?name=test_mm_plus_mm&suite=TestPatternMatcher&limit=100
Double clicking on the row brings you to
https://torchci-git-csl-testx-fbopensource.vercel.app/tests/testInfo?name=test_mm_plus_mm&suite=TestPatternMatcher&file=inductor%2Ftest_pattern_matcher.py
which looks like this after loading