Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUD] Better test info pages #6211

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[HUD] Better test info pages #6211

merged 4 commits into from
Jan 29, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jan 22, 2025

https://hud.pytorch.org/flakytest?name=test_mm_plus_mm&suite=TestPatternMatcher&limit=100

Changes the flakytest page to redirect to a search page. Double clicking on a row brings you to a page about the individual test. The individual test page has a bar chart of runs from the past 3 days, and the info that used to be on the flakytest page (list of jobs the test failed or was rerun)

Old:
image
New:
https://torchci-git-csl-testx-fbopensource.vercel.app/flakytest?name=test_mm_plus_mm&suite=TestPatternMatcher&limit=100
image
Double clicking on the row brings you to
https://torchci-git-csl-testx-fbopensource.vercel.app/tests/testInfo?name=test_mm_plus_mm&suite=TestPatternMatcher&file=inductor%2Ftest_pattern_matcher.py
which looks like this after loading
image

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jan 29, 2025 5:46pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@clee2000 clee2000 marked this pull request as ready for review January 22, 2025 23:55
@clee2000 clee2000 requested a review from a team January 22, 2025 23:56
select
t.name,
t.classname,
t.file,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file comes from pytest/the test runner and invoking file comes from run_test.py and is not formatted the same way a file name is. I'm not sure about which is more accurate, especially in the case of cpp files, so it shows both

@huydhn
Copy link
Contributor

huydhn commented Jan 28, 2025

Some more thoughts I have:

@clee2000
Copy link
Contributor Author

  • The 2 search box is a bit confusing

I am not sure which part this refers to but I changed the job filter to say filter instead of search, which might help?

@clee2000 clee2000 merged commit 19c56ae into main Jan 29, 2025
6 checks passed
@clee2000 clee2000 deleted the csl/testx branch January 29, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants