Always show time range picker on benchmark dashboard #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yangw-dev
approved these changes
Jan 30, 2025
torchci/pages/benchmark/llms.tsx
Outdated
| /> | ||
| </Stack> | ||
| <Stack> | ||
| <>Loading {REPO_TO_BENCHMARKS[repoName].join(", ")}...</> |
There was a problem hiding this comment.
it can be a little confusing for loading statement, maybe something indicate no data is found/
"No record detected {REPO_TO_BENCHMARKS[repoName].join(", ")}, please select different time range"
There was a problem hiding this comment.
Yeah, this message is quite vague
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6222
This is a minor tweak to always show time range picker on benchmark dashboard so that people can choose a larger window than 7 days when there is no data.
Testing
https://hud.pytorch.org/benchmark/llms?repoName=pytorch%2Fao shows nothing as nothing has been run in the last 7 days
https://torchci-git-fork-huydhn-fix-dashboard-no-da-e651c3-fbopensource.vercel.app/benchmark/llms?repoName=pytorch%2Fao at least show the option to increase the time range to show older data