-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Utilization] Set up Job level profile, and test detail mechanism #6264
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The page looks good, but there are some redundant information that I'm not sure if we want to show to its user:
|
Thx for the feedback, will work on some of those!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense if the "We detected (24) tests on python_CMD level, click on the test name to see the location of the test" section and the "Click on the graph chart to see the test details." section were combined. For example, clicking on a test in the "We detected (24) tests on python_CMD level, click on the test name to see the location of the test:" would show the location of the test and set the "Selected Test Details" section. Or clicking on the "Single Test Details" would also set the display in the "We detected (24) tests on python_CMD level, click on the test name to see the location of the test:" section
my next step is make two flows :
but this will be next step after this |
Description
show job profile information such as duration, cpu, gpu count etc.
show the total statisctics table for the whole job.
show detected testsand tests' segmented Statistics Table
Currently we only show max aggregate data,
the max agg: we get the max of a utilization percentage during the 5 sec collect interval.
the avg agg: we get the avg of all utilization percentage during the 5 sec collect interval
Statistics Table
show all hardware's max aggregated data for avg, 10p,90p and 90% utilizaiton spike info.
Will add analysis seciton for the statistics in next step
Demo
working vercel demo link:
Job with GPU: https://torchci-qrqc2igy4-fbopensource.vercel.app/utilization/13143119394/36681447812/1
Job without GPU: https://torchci-qrqc2igy4-fbopensource.vercel.app/utilization/12937937547/36088234580/1
Job Profile Details
workflow and job information, duration, hardware count information
a statisctics table shows how the whole job's utilization behaves.
View Tests
Two options to view detected test details:
Choose single test from list view
choose singl test from chart view
Other
remove .curve(d3.curveBasis) from the svg since it does not render svg accurate
Next step
add more test related rendering and table for test improvement recommendation