Remove unused memory checks to speed up compute
#2719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
atuljangra
added a commit
to atuljangra/torchrec
that referenced
this pull request
Feb 1, 2025
Summary: Pull Request resolved: pytorch#2719 The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here. In our runs, this accounted for around 20% time spent in the rec metric compute step. Given that this is not being used anymore, let's remove this call. This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites. Differential Revision: D68995122
atuljangra
force-pushed
the
export-D68995122
branch
from
79d9099 to
ecdabfd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
atuljangra
added a commit
to atuljangra/torchrec
that referenced
this pull request
Feb 1, 2025
Summary: The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here. In our runs, this accounted for around 20% time spent in the rec metric compute step. Given that this is not being used anymore, let's remove this call. This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites. Reviewed By: fegin Differential Revision: D68995122
atuljangra
force-pushed
the
export-D68995122
branch
from
ecdabfd to
0d39b2d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
atuljangra
added a commit
to atuljangra/torchrec
that referenced
this pull request
Feb 2, 2025
Summary: Pull Request resolved: pytorch#2719 The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here. In our runs, this accounted for around 20% time spent in the rec metric compute step. Given that this is not being used anymore, let's remove this call. This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites. Reviewed By: fegin Differential Revision: D68995122
atuljangra
force-pushed
the
export-D68995122
branch
from
0d39b2d to
c743013
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
atuljangra
added a commit
to atuljangra/torchrec
that referenced
this pull request
Feb 2, 2025
Summary: Pull Request resolved: pytorch#2719 The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here. In our runs, this accounted for around 20% time spent in the rec metric compute step. Given that this is not being used anymore, let's remove this call. This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites. Reviewed By: fegin Differential Revision: D68995122
atuljangra
force-pushed
the
export-D68995122
branch
from
c743013 to
37938e7
Compare
Summary: The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here. In our runs, this accounted for around 20% time spent in the rec metric compute step. Given that this is not being used anymore, let's remove this call. This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites. Reviewed By: fegin Differential Revision: D68995122
atuljangra
force-pushed
the
export-D68995122
branch
from
37938e7 to
14b341c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68995122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The memory checks here have non-significant overhead in every compute step as there are a lot of tensor size calls involved here.
In our runs, this accounted for around 20% time spent in the rec metric compute step.
Given that this is not being used anymore, let's remove this call.
This diff removes the call from the metric_module. In the next set of diffs, I'll remove the argument from the callsites.
Differential Revision: D68995122