refactor config manager and support cmd overrides (#157)

This PR supports explicit cmd overrides, to allow infra layers to override certain options (the most important one is dump_folder)
pytorch · Mar 22, 2024 · 72aad15 · 72aad15
1 parent f7c22c5
commit 72aad15
Show file tree

Hide file tree

Showing 4 changed files with 130 additions and 78 deletions.
diff --git a/test/test_job_config.py b/test/test_job_config.py
@@ -28,3 +28,15 @@ def test_empty_config_file(self):
             config = JobConfig()
             config.parse_args(["--job.config_file", fp.name])
             assert config.job.description
+
+    def test_job_config_file_cmd_overrides(self):
+        config = JobConfig()
+        config.parse_args(
+            [
+                "--job.config_file",
+                "./train_configs/debug_model.toml",
+                "--job.dump_folder",
+                "/tmp/test_tt/",
+            ]
+        )
+        assert config.job.dump_folder == "/tmp/test_tt/"