Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes fused_rmsnorm #826

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

allenwang28
Copy link
Contributor

Context in #825.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 6, 2025
@allenwang28 allenwang28 marked this pull request as ready for review February 6, 2025 17:58
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allenwang28 allenwang28 linked an issue Feb 6, 2025 that may be closed by this pull request
@allenwang28 allenwang28 merged commit 37c4b81 into pytorch:main Feb 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fused_rmsnorm as an option
4 participants