Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework recipes section of README and simplify models ref #2349

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joecummings
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Feb 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2349

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 59bf1da with merge base 9f14fe9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
README.md Outdated

| Method | Type of Weight Update | 1 Device | >1 Device | >1 Node |
|------------------------------|-----------------------|:--------:|:---------:|:-------:|
| DPO | Full | ✅ | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to live docs (as and when we have them)? https://pytorch.org/torchtune/main/recipes/dpo.html

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.37%. Comparing base (e6b9064) to head (59bf1da).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2349       +/-   ##
===========================================
+ Coverage   23.72%   64.37%   +40.65%     
===========================================
  Files         361      356        -5     
  Lines       21492    20969      -523     
===========================================
+ Hits         5098    13498     +8400     
+ Misses      16394     7471     -8923     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joecummings joecummings changed the title Simplify recipes section of readme Rework recipes section of README and simplify models ref Feb 6, 2025
README.md Outdated
| [Qwen2.5](https://qwenlm.github.io/blog/qwen2.5/) | 0.5B, 1.5B, 3B, 7B, 14B, 32B, 72B [[models](torchtune/models/qwen2_5/), [configs](recipes/configs/qwen2_5/)]

We're always adding new models, but feel free to [file an issue](https://github.com/pytorch/torchtune/issues/new) if there's a new one you would like to see in torchtune.
torchtune supports different kinds of post-training. A successful post-trained model will likely utilize several of the below methods.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should also just link to the recipe overview in here https://pytorch.org/torchtune/main/recipes/recipes_overview.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants