Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cfg.cudnn_deterministic_mode flag #2367

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

bogdansalyp
Copy link
Contributor

@bogdansalyp bogdansalyp commented Feb 9, 2025

Context

What is the purpose of this PR? Is it to

Please link to any issues this PR addresses.

Changelog

cfg.deterministic_mode added for reproducibility

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Feb 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2367

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 974cabb with merge base fb52557 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bogdansalyp bogdansalyp marked this pull request as draft February 9, 2025 02:10
@facebook-github-bot
Copy link

Hi @bogdansalyp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@bogdansalyp bogdansalyp marked this pull request as ready for review February 10, 2025 18:06
@bogdansalyp bogdansalyp marked this pull request as draft February 10, 2025 18:06
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@bogdansalyp
Copy link
Contributor Author

bogdansalyp commented Feb 10, 2025

llama3_1 8B_lora_dpo as an example (tested on other recipes and models too)

image image

@bogdansalyp bogdansalyp marked this pull request as ready for review February 10, 2025 19:20
Copy link
Contributor

@pbontrager pbontrager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, my only concern is that the name is too generic as this only affects cudnn backends. Maybe cuda_deterministic_mode?

@bogdansalyp
Copy link
Contributor Author

bogdansalyp commented Feb 10, 2025

This looks good, my only concern is that the name is too generic as this only affects cudnn backends. Maybe cuda_deterministic_mode?

agree, that may be a better naming

UPD: renamed to cudnn_deterministic_mode

@bogdansalyp bogdansalyp changed the title feat: Added cfg.deterministic_mode flag feat: Added cfg.cudnn_deterministic_mode flag Feb 10, 2025
@pbontrager pbontrager merged commit 386ca8d into pytorch:main Feb 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed is not applied for DPO recipes
3 participants